Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental/EIP1193Bridge: fix getCode call #3166

Closed
wants to merge 1 commit into from
Closed

Experimental/EIP1193Bridge: fix getCode call #3166

wants to merge 1 commit into from

Conversation

mmv08
Copy link

@mmv08 mmv08 commented Jul 13, 2022

This PR fixes relaying eth_getCode call to provider.getBlock by relaying it to provider.getCode.

The PR includes many changes for package-lock.json because my npm complained about the outdated lockfile format and wanted to regenerate it completely. I'm on npm 8.13.2, which is the latest version. I can revert this change if needed.

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Jul 14, 2022
@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Jul 14, 2022
@mmv08
Copy link
Author

mmv08 commented Jul 14, 2022

Hey @ricmoo, thanks for fixing this. I assume I can close this PR then? And do you have any rough estimation of when 5.7 will be released?

@ricmoo
Copy link
Member

ricmoo commented Jul 14, 2022

You can keep it open. I’ll close it once I publish the v5.7.0 release. :)

@ricmoo
Copy link
Member

ricmoo commented Aug 19, 2022

This has been fixed in v5.7.0.

Thanks! :)

@ricmoo ricmoo closed this Aug 19, 2022
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Aug 19, 2022
@mmv08 mmv08 deleted the bug/eip1193-bridge-getcode branch August 21, 2022 10:16
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants